[PATCH] D100167: [AIX] Adjust CSR order to avoid breaking ABI regarding traceback

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.td:291
+  let AltOrders = [(add (sub GPRC, R2), R2),
+                   (add (sequence "R%u", 2, 12),
+                        (sequence "R%u", 31, 13), R0, R1, FP, BP)];
----------------
Add comments about the AIX sequence.


================
Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.td:294
   let AltOrderSelect = [{
-    return MF.getSubtarget<PPCSubtarget>().is64BitELFABI();
+    if (MF.getSubtarget<PPCSubtarget>().is64BitELFABI())
+      return 1;
----------------
Please make this a Subtarget function, something like `PPCSubtarget::getGPRAllocationOrder`, so that we don't need to duplicate code here.


================
Comment at: llvm/test/CodeGen/PowerPC/inc-of-add.ll:165
 ;
-; PPC64BE-LABEL: vector_i128_i8:
-; PPC64BE:       # %bb.0:
----------------
Why removing these lines?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100167/new/

https://reviews.llvm.org/D100167