[PATCH] D101107: [AIX][Power10] Restrict prefixed instructions from crossing the 64byte boundary

Amy Kwan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 18:06:12 PDT 2021


amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFStreamer.cpp:2
+//===-------- PPCXCOFFStreamer.cpp - XCOFF Object Output
+//---------------------===//
+//
----------------
Should this be on the previous line?


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFStreamer.cpp:17
+// because 8 byte instructions are not allowed to cross 64 byte boundaries
+// and by aliging anything that is within 4 bytes of the boundary we can
+// guarantee that the 8 byte instructions do not cross that boundary.
----------------
Minor typo.


================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCXCOFFStreamer.h:2
+//===- PPCXCOFFStreamer.h - XCOFF Object Output --------------------*- C++
+//-*-===//
+//
----------------
Should the previous line be reformatted so everything fits on a single line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101107/new/

https://reviews.llvm.org/D101107



More information about the llvm-commits mailing list