[PATCH] D76519: [NFC] Refactor how CFI section types are represented in AsmPrinter

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 15:18:42 PDT 2021


MaskRay reopened this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

I am sorry but I reverted this in e01c666b136e3f97587b22a2029f31e5c36a0e71 <https://reviews.llvm.org/rGe01c666b136e3f97587b22a2029f31e5c36a0e71>.

  D76519 was not quite NFC. If we see a CFISection::Debug function before a
  CFISection::EH one (-fexceptions -fno-asynchronous-unwind-tables), we may
  incorrectly pick CFISection::Debug and emit a `.cfi_sections .debug_frame`.
  We should use .eh_frame instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76519/new/

https://reviews.llvm.org/D76519



More information about the llvm-commits mailing list