[PATCH] D100575: [flang][OpenMP][FIX] Fix the worksharing nesting check with inclusion of more constructs to cover entire workshare family.

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan requested changes to this revision.
kiranchandramohan added inline comments.
This revision now requires changes to proceed.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:45
 static OmpDirectiveSet doSet{Directive::OMPD_distribute_parallel_do,
     Directive::OMPD_distribute_parallel_do_simd, Directive::OMPD_parallel,
     Directive::OMPD_parallel_do, Directive::OMPD_parallel_do_simd,
----------------
Not sure why parallel is here. Remove if no test fails.


================
Comment at: flang/lib/Semantics/check-omp-structure.h:71-75
+    llvm::omp::Directive::OMPD_workshare,
+    Directive::OMPD_parallel_workshare,
+    Directive::OMPD_parallel_sections,
+    llvm::omp::Directive::OMPD_sections,
+    llvm::omp::Directive::OMPD_single,
----------------
Why do a few of these have the llvm::omp prefix but others do not?


================
Comment at: flang/lib/Semantics/check-omp-structure.h:76
+    llvm::omp::Directive::OMPD_single,
+
+};
----------------
Nit: empty line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100575/new/

https://reviews.llvm.org/D100575