[PATCH] D101286: [LAA] Support pointer phis in loop by analyzing each incoming pointer.

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

Makes sense to me.

Pre-merge bot could not apply the patch, possibly because you diffed it against a commit that is not upstream.



================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:1947
+          PN->getParent() != TheLoop->getHeader()) {
+        for (const auto &Inc : PN->incoming_values()) {
+          MemoryLocation NewLoc = Loc.getWithNewPtr(Inc);
----------------
[style] [[ https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable | Don’t “almost always” use auto ]]


================
Comment at: llvm/lib/Analysis/LoopAccessAnalysis.cpp:2001
+        PN->getParent() != TheLoop->getHeader()) {
+      for (const auto &Inc : PN->incoming_values()) {
+        MemoryLocation NewLoc = Loc.getWithNewPtr(Inc);
----------------
[style] [[ https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable | Don’t “almost always” use auto ]]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101286/new/

https://reviews.llvm.org/D101286