[PATCH] D101211: [ADT] Remove StatisticBase and make NoopStatistic empty

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D101211#2717753 <https://reviews.llvm.org/D101211#2717753>, @dblaikie wrote:

> "has 3 unused pointers" is the bit I had in mind in terms of modifying the description - that statement seems incorrect to me (in the presence of the LoopFuse usage). So I was thinking something like "has 3 mostly unused pointers" and then down at the end
>
> "the one use of these pointers is in LoopFuse (an unused pass) for printing out an optimization remark - for now that usage has been #ifdef'd out, if it's desirable to have the remark, it could use a different abstraction to keep track of the strings, or these particular statistics could be hardcoded to TrackingStatistic"

Oh, did not see this when I pushed the commit (I had a script running the last round of testing before pushing).

Yes, `has 3 mostly unused pointers` would be more accurate

> "the one use of these pointers is in LoopFuse (an unused pass) for printing out an optimization remark - for now that usage has been #ifdef'd out, if it's desirable to have the remark, it could use a different abstraction to keep track of the strings, or these particular statistics could be hardcoded to TrackingStatistic"

This description would be more accurate as well:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101211/new/

https://reviews.llvm.org/D101211