[PATCH] D101291: [IndVars] avoid crash in LFTR when assuming an add recurrence

Mon Apr 26 13:41:28 PDT 2021

spatel added a comment.

In D101291#2717400 <https://reviews.llvm.org/D101291#2717400>, @reames wrote:

> This patch looks suspiciously like it's fixing a symptom not the cause.  The test case in this review does not reproduce for me.  However, the original reduced case from the mentioned bug does.

Note: I don't disagree with any of the comments and/or reworking this patch, but I'd like to make sure we are seeing the same thing. When you tested locally, did you include a data layout? Without that, I suspect we bail out early without trying any transforms.
The regression test file that I am adding to has:
`target datalayout = "n8:16:32:64"`

We need the `n32` at least to get into trouble in my testing.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101291/new/

https://reviews.llvm.org/D101291