[compiler-rt] a786f2b - [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

Leonard Chan via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 13:26:31 PDT 2021


Author: Leonard Chan
Date: 2021-04-26T13:25:10-07:00
New Revision: a786f2badc41459c713668eabe2b0053e4d8132a

URL: https://github.com/llvm/llvm-project/commit/a786f2badc41459c713668eabe2b0053e4d8132a
DIFF: https://github.com/llvm/llvm-project/commit/a786f2badc41459c713668eabe2b0053e4d8132a.diff

LOG: [compiler-rt][hwasan] Add definition for Symbolizer::SymbolizeFrame

This is undefined if SANITIZER_SYMBOLIZER_MARKUP is 1, which is the case for
Fuchsia, and will result in a undefined symbol error. This function is needed
by hwasan for online symbolization, but is not needed for us since we do
offline symbolization.

Differential Revision: https://reviews.llvm.org/D99386

Added: 
    

Modified: 
    compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp
index 30cba08ed5390..01edef9c1aa9b 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_markup.cpp
@@ -54,6 +54,10 @@ bool Symbolizer::GetModuleNameAndOffsetForPC(uptr pc, const char **module_name,
   return false;
 }
 
+// This is mainly used by hwasan for online symbolization. This isn't needed
+// since hwasan can always just dump stack frames for offline symbolization.
+bool Symbolizer::SymbolizeFrame(uptr addr, FrameInfo *info) { return false; }
+
 // This is used in some places for suppression checking, which we
 // don't really support for Fuchsia.  It's also used in UBSan to
 // identify a PC location to a function name, so we always fill in


        


More information about the llvm-commits mailing list