[PATCH] D101320: [Inliner] Make ModuleInlinerWrapperPass return PreservedAnalyses::all()
Arthur Eubanks via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 26 13:02:03 PDT 2021
aeubanks created this revision.
aeubanks added reviewers: asbirlea, mtrofin.
Herald added subscribers: hiraditya, eraman.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
The ModulePassManager should already have taken care of all analysis
invalidation. Without this change, upcoming changes will cause more
invalidation than necessary.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D101320
Files:
llvm/lib/Transforms/IPO/Inliner.cpp
Index: llvm/lib/Transforms/IPO/Inliner.cpp
===================================================================
--- llvm/lib/Transforms/IPO/Inliner.cpp
+++ llvm/lib/Transforms/IPO/Inliner.cpp
@@ -1036,8 +1036,10 @@
else
MPM.addPass(createModuleToPostOrderCGSCCPassAdaptor(
createDevirtSCCRepeatedPass(std::move(PM), MaxDevirtIterations)));
- auto Ret = MPM.run(M, MAM);
+ MPM.run(M, MAM);
IAA.clear();
- return Ret;
+
+ // The ModulePassManager has already taken care of invalidating analyses.
+ return PreservedAnalyses::all();
}
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101320.340617.patch
Type: text/x-patch
Size: 558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210426/5527a557/attachment.bin>
More information about the llvm-commits
mailing list