[PATCH] D101309: [NewPM] Remove ModuleInlinerWrapperPass and directly add passes to PMs

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 10:24:17 PDT 2021


aeubanks created this revision.
aeubanks added reviewers: asbirlea, mtrofin.
Herald added subscribers: hiraditya, eraman.
aeubanks requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ModuleInlinerWrapperPass is a unique pass in that it creates its own
pass manager and runs that. This causes unnecessary nesting. Besides
making some pipeline tests longer, it can also cause more invalidation
than necessary. At the top level ModulePassManager we can ignore the
returned PreservedAnalyses. But if there is a sub-ModulePassManager, the
outer ModulePassManager must invalidate based on the returned
PreservedAnalyses.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101309

Files:
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/include/llvm/Transforms/IPO/Inliner.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/IPO/Inliner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101309.340578.patch
Type: text/x-patch
Size: 12405 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210426/33d1205e/attachment-0001.bin>


More information about the llvm-commits mailing list