[PATCH] D101288: Only ignore -Wdeprecated-copy if the used compiler supports the warning

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 09:16:41 PDT 2021


xbolva00 added a comment.

In D101288#2716930 <https://reviews.llvm.org/D101288#2716930>, @uabelho wrote:

> In D101288#2716923 <https://reviews.llvm.org/D101288#2716923>, @uabelho wrote:
>
>> Use
>>  #ifdef __clang__
>>  #if __has_warning("-Wdeprecated-copy")
>> instead of 
>> #if defined(__clang__) && __has_warning("-Wdeprecated-copy")
>> as the latter seems to break gcc bots.
>
> I have no idea if this is the best fix but it works for me with clang 8 and gcc 9.3.0.

Best fix is remove all deprecated things but yeah, for know this is ok.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101288/new/

https://reviews.llvm.org/D101288



More information about the llvm-commits mailing list