[PATCH] D100446: [Transforms][Debugify] Fix "Missing line" false alarm on PHI nodes

Mon Apr 26 07:35:12 PDT 2021

djtodoro added a comment.

In D100446#2715753 <https://reviews.llvm.org/D100446#2715753>, @xiangzhangllvm wrote:

> In D100446#2712464 <https://reviews.llvm.org/D100446#2712464>, @djtodoro wrote:
>
>> So this patch will remove reporting warnings of missing debug loc to PHIs completely, right?
>
> Yes
>
>> Can we at least introduce an option to keep checking the PHIs, because there are cases it can be a real issue detected by debugify.
>
> Of course we can. But this warning just for pass generate PHI, we usually ignore warnings if they are make sense. I think the reason @Nuullll write this patch is just that "PHI existed in too many passes, but very few pass generate PHI"

got it, thanks. This lgtm.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100446/new/

https://reviews.llvm.org/D100446