[PATCH] D98650: [NVPTX] Enable lowering of atomics on local memory

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Only minor nits from me, @tra, you should review this I suppose.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXAtomicLower.cpp:45
+bool NVPTXAtomicLower::runOnFunction(Function &F) {
+  SmallVector<AtomicRMWInst *, 3> LocalMemoryAtomics;
+  for (BasicBlock &BB : F) {
----------------



================
Comment at: llvm/lib/Target/NVPTX/NVPTXAtomicLower.cpp:54
+    }
+  }
+  bool Changed = false;
----------------
Nit: `for (Instructions &I : instructions(F))`
I would omit the braces, also below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98650/new/

https://reviews.llvm.org/D98650