[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 26 04:49:26 PDT 2021
aaron.ballman accepted this revision.
aaron.ballman added a comment.
Just one drive-by nit from me.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4119-4123
+ if (LangOpts.SYCLIsDevice) {
+ if (!D || D->getType().getAddressSpace() == LangAS::Default) {
+ return LangAS::sycl_global;
+ }
+ }
----------------
Just simplifying the logic a bit, likely needs to be reformatted though.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89909/new/
https://reviews.llvm.org/D89909
More information about the llvm-commits
mailing list