[PATCH] D99736: [MIPatternMatch]: Add matchers for binary instructions

[Jay Foad via Phabricator via llvm-commits]

foad added a comment.

I'm not sure the "AnyBinaryOp" versions are really needed for anything -- see https://reviews.llvm.org/D90050#inline-955365.

As for BinaryOpWithOpcode_match, couldn't you just change the existing BinaryOp_match to take the opcode as a regular argument instead of a template argument? (Are you worried about making it slower? Hopefully with proper inlining there would be no codegen difference at all.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99736/new/

https://reviews.llvm.org/D99736