[PATCH] D101135: [Utils][vim] Highlight CHECK-EMPTY: & CHECK-COUNT: directives

Cassie Jones via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 03:43:51 PDT 2021


porglezomp accepted this revision.
porglezomp added a comment.
This revision is now accepted and ready to land.

Style nit on quote-vs-slash, but otherwise this looks good to me.



================
Comment at: llvm/utils/vim/syntax/llvm.vim:237-238
 syn match  llvmSpecialComment /;\s*CHECK:.*$/
-syn match  llvmSpecialComment "\v;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL):.*$"
+syn match  llvmSpecialComment ";\s*CHECK-EMPTY:\s*$"
+syn match  llvmSpecialComment "\v;\s*CHECK-(NEXT|NOT|DAG|SAME|LABEL|COUNT-\d+):.*$"
 syn match  llvmSpecialComment /;\s*XFAIL:.*$/
----------------
Minor nit, I don't think there's any reason these patterns need to use quotes, they could be changed to slash to match all of the surrounding patterns


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101135/new/

https://reviews.llvm.org/D101135



More information about the llvm-commits mailing list