[PATCH] D100218: Fix for "Bug 49146 - Crash with MIPS16 multiply"

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan added inline comments.


================
Comment at: clang/test/CodeGen/mips16-mult.c:1
+// REQUIRES: mips-registered-target
+// RUN: %clang --target=mipsel-unknown-linux -mips16 -c -o %t %s
----------------
1. You need to create a test case in the `llvm/test/CodeGen/Mips` folder. Sometimes LLVM build without Clang.
2. Test case should check result of code generation. Not only the fact that the program does not crash.


================
Comment at: llvm/lib/Target/Mips/MipsISelLowering.cpp:208
   case MipsISD::Multu:             return "MipsISD::Multu";
+  case MipsISD::Mult16:
+    return "MipsISD::Mult16";
----------------
It's better to keep formattings the same as the code around.


================
Comment at: llvm/lib/Target/Mips/MipsISelLowering.h:57
 
-    enum NodeType : unsigned {
-      // Start the numbering from where ISD NodeType finishes.
----------------
Please revert this too big change unrelated to this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100218/new/

https://reviews.llvm.org/D100218