[PATCH] D101042: [AArch64] Add missing UINT_TO_FP promotions for v16i8

[Joe Ellis via Phabricator via llvm-commits]

joechrisellis added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-fixed-length-fp-converts.ll:175
+define void @uitofp_v4i8_v4f32(<4 x i8>* %in, <4 x float>* %out) #0 {
+; CHECK-LABEL: uitofp_v4i8_v4f32:
+  %vec = load <4 x i8>, <4 x i8>* %in
----------------
david-arm wrote:
> Shouldn't we have some CHECK lines for the codegen in these functions?
Hi @david-arm -- the codegen here is not particularly interesting at the moment (and is actually quite poor). These functions are actually defending against selection failures. At this point I'm not entirely convinced that writing CHECK lines for the codegen here is valuable. Do we definitely need them? 🙂


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101042/new/

https://reviews.llvm.org/D101042