[PATCH] D48811: Fix disassembling ARM instructions as big-endian
David Spickett via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 26 03:05:02 PDT 2021
DavidSpickett added a comment.
I would use `support::endian::endianness` instead of a bool. Then you can remove the `/*isLittleEndian=*/` comments and use the read calls that take an endianness. E.g. `uint16_t read16(const void *P, endianness E);`.
I assume `armv7eb` would work out of the box, given that llvm-objdump already knows the file is big endian. (I thought there might be some ELF attribute we needed to look for)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D48811/new/
https://reviews.llvm.org/D48811
More information about the llvm-commits
mailing list