[PATCH] D101005: [AArch64][GlobalISel] Simplify out of range rotate amount.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 26 02:23:35 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:3918-3919
+
+  return ConstantFoldBinOp(TargetOpcode::G_UREM, OrigAmtCst, BitSizeCst)
+      .hasValue();
+}
----------------
Why not just return true? Why would this ever fail?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101005/new/

https://reviews.llvm.org/D101005



More information about the llvm-commits mailing list