[PATCH] D99785: [XCOFF] make .file directive have directory info

Mon Apr 26 02:19:25 PDT 2021

shchenz added a comment.

In D99785#2715798 <https://reviews.llvm.org/D99785#2715798>, @hubert.reinterpretcast wrote:

> In D99785#2715170 <https://reviews.llvm.org/D99785#2715170>, @shchenz wrote:
>
>> @hubert.reinterpretcast thanks for providing the example. Yes, it is indeed an issue for the same name in symbol table and in dwinfo section.
>>  As you can see in link https://www.ibm.com/docs/en/aix/7.2?topic=files-file-naming-conventions , special characters are not recommmended to be used in the file name, so can we just ignore the special characters and only handle the directory info in this patch? Thanks.
>
> The file name conventions on AIX does not (and probably cannot) recommend against the use of "national characters". The character escape mechanism being applied is incorrect. The string constants in AIX assembly are mostly-raw strings, with double quotation marks in the string content being immediately repeated to indicate that the end-of-string has not been reached.

Thanks, the special characters handling will be handled in patch D101280 <https://reviews.llvm.org/D101280>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99785/new/

https://reviews.llvm.org/D99785