[PATCH] D101260: [LoopVectorize][SVE] Remove assert for scalable vector in InnerLoopVectorizer::fixReduction

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

The fix looks good thanks! Just a minor comment about the test ...



================
Comment at: llvm/test/Transforms/LoopVectorize/sve-reduction-inloop.ll:12
+; CHECK-NEXT:  %[[ICMP1:.*]] = icmp eq i32 %[[INDEXNEXT]], %{{.*}}
+; CHECK-NEXT:  %[[TRUNC1:.*]] = trunc <vscale x 8 x i32> %{{.*}} to <vscale x 8 x i8>
+; CHECK-NEXT:  %[[ZEXT1:.*]] = zext <vscale x 8 x i8> %[[TRUNC1]] to <vscale x 8 x i32>
----------------
Hi @CarolineConcatto, I presume this is a truncation of the PHI value? If possible I think it might be nice to have CHECK lines for the PHI values to see them being truncated. I think that ZEXT1 and ZEXT2 will also be the incoming values for the PHI node too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101260/new/

https://reviews.llvm.org/D101260