[PATCH] D100628: [Debug-Info][DBX] DW_AT_noreturn should not be generated when dwarf version is not 5

[ChenZheng via Phabricator via llvm-commits]

shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:1281
+  if (SP->isNoReturn() &&
+      (!Asm->TM.Options.DebugStrictDwarf || DD->getDwarfVersion() >= 5))
     addFlag(SPDie, dwarf::DW_AT_noreturn);
----------------
aprantl wrote:
> Should we factor out a FlagSupported(attribute) function? I think Dwarf.def already stores the version in which an attribute was introduced, so we don't need to duplicate this in the code here?
Thanks Adrian, @aprantl . Great minds think alike, haha. All of you, including @probinson and @dblaikie have the same opinions for this change. I have added the function in D101125 and abandoned related patches including this one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100628/new/

https://reviews.llvm.org/D100628