[PATCH] D100331: [Dependence Analysis] Fix ExactSIV producing wrong analysis

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added inline comments.


================
Comment at: llvm/test/Analysis/DependenceAnalysis/Coupled.ll:253
 ; CHECK: da analyze - none!
-; CHECK: da analyze - flow [<]!
+; CHECK: da analyze - flow [=|<]!
 ; CHECK: da analyze - confused!
----------------
bmahjour wrote:
> this one was wrong before, and is still wrong but in a different way....same thing with couple14.
This is marked as done, but I don't see being it addressed.


================
Comment at: llvm/test/Analysis/DependenceAnalysis/ExactSIV.ll:19
 ; CHECK: da analyze - none!
-; CHECK: da analyze - flow [>]!
+; CHECK: da analyze - flow [<=|<]!
 ; CHECK: da analyze - confused!
----------------
bmahjour wrote:
> The `<=` part is correct, but I'm not sure about the `|<` part. The dependence is loop carried for the most part (except when i = 9). I think this might be because we treat the existence of an `EQ` as signifying loop independent dependence, which should probably be reconsidered in a separate patch.
This is marked as done, but I don't see being it addressed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100331/new/

https://reviews.llvm.org/D100331