[PATCH] D101264: [IR] Optimize mayBeDerefined for known linkages. NFC

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D101264#2715553 <https://reviews.llvm.org/D101264#2715553>, @dblaikie wrote:

> Is this functionally changing behavior? (looks like it is, because the 'false' return could currently be overriden by the SemanticInterposable module metadata, resulting in a 'true' return even for these linkages?) If it is a functional change it should have test coverage at least.
>
> (though I think it's unfortunate that this would make the noipa work more involved & add more slices of behavior that could be incorrectly used)

No. InternalLinkage and PrivateLinkage imply dso_local. dso_preemptable AppendingLinkage doesn't make sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101264/new/

https://reviews.llvm.org/D101264