[PATCH] D100704: [Thumb1][MachineOutliner] Add Machine Outliner support for Thumb1

Benson Chu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 25 13:44:05 PDT 2021


pestctrl marked an inline comment as done.
pestctrl added inline comments.


================
Comment at: llvm/lib/Target/ARM/Thumb1InstrInfo.cpp:360
+  // the LR twice.
+  Register RegToSave = LiveReg ? FreeReg : ARM::LR;
+  assert(FreeReg != 0 && "No callee-saved register available?");
----------------
yroux wrote:
> why not adding FreeReg to MBB's LiveIns instead of spilling LR twice ?
Huh, I had no idea you could do this. This might simplify my code a lot. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100704/new/

https://reviews.llvm.org/D100704



More information about the llvm-commits mailing list