[PATCH] D100865: [COST] Improve shuffle kind detection if shuffle mask is provided.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 25 12:34:30 PDT 2021


ABataev added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:753
+    case TTI::SK_PermuteTwoSrc:
+      if (ShuffleVectorInst::isSelectMask(Mask))
+        return TTI::SK_Select;
----------------
dmgreen wrote:
> Some of these Mask functions do not handle all sizes of mask. Do we need to be careful about shuffles that changesLength?
Here we don't have info about length changes, looks like all these functions use the size of the Mask array as vector factor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100865/new/

https://reviews.llvm.org/D100865



More information about the llvm-commits mailing list