[PATCH] D99785: [XCOFF] make .file directive have directory info

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 25 01:45:43 PDT 2021


shchenz added a comment.

In D99785#2671112 <https://reviews.llvm.org/D99785#2671112>, @hubert.reinterpretcast wrote:

> From what I understand, this is meant to fix a situation where `dbx` is unhappy when the file is not simply compiled in the directory where it resides (using its basename). However, this unhappiness extends even to the compiled-using-basename case when the filename contains "special characters".
>
> For example, a file with a tab character ends up with backslash escapes in the assembly (but the assembler on AIX doesn't interpret these):
>
>   $ clang -mllvm -dwarf-inlined-strings=Enable a\    q.c -S -o - | grep -F .file
>           .file   "a\tq.c"

@hubert.reinterpretcast thanks for providing the example. Yes, it is indeed an issue for the same name in symbol table and in dwinfo section.
 As you can see in link https://www.ibm.com/docs/en/aix/7.2?topic=files-file-naming-conventions , special characters are not recommmended to be used in the file name, so can we just ignore the special characters and only handle the directory info in this patch? Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99785/new/

https://reviews.llvm.org/D99785



More information about the llvm-commits mailing list