[PATCH] D100585: [ARM][disassembler] Fix incorrect number of operands MCInst generated by the disassembler

Sun Apr 25 00:51:28 PDT 2021

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM.

================
Comment at: llvm/test/MC/Disassembler/ARM/bug49974.arm.txt:1
+# RUN: llvm-mc -triple=arm -disassemble -show-inst < %s | FileCheck %s
+
----------------
I would name these tests after the instruction they are testing, not the bug number.

================
Comment at: llvm/test/MC/Disassembler/ARM/bug49974.thumb2.txt:15
+
+0xad 0xf2 0x7c 0x4d
----------------
May be worth adding quick tests for t2SUBspImm with and without S, to make sure they are still doing OK too. They seem fine but it can be good to have the test.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100585/new/

https://reviews.llvm.org/D100585