[PATCH] D89493: [lit] Implement `not` as a builtin in the Lit internal shell

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 24 11:27:13 PDT 2021


dexonsmith added inline comments.


================
Comment at: llvm/utils/lit/lit/builtin_commands/not.py:33
+    if found is None:
+        sys.stderr.write('Failed to find program {}\n'.format(prog))
+    return found
----------------
delcypher wrote:
> Do we need to call `sys.stderr.flush()` here? I recently ran into a problem with `sys.stdout` where I needed to do this to ensure it gets written out but I'm not sure about stderr.
I don't know for sure about python, but usually stdout is buffered and stderr isn't.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89493/new/

https://reviews.llvm.org/D89493



More information about the llvm-commits mailing list