[PATCH] D99990: [NewGVN] Use performSymbolicEvaluation instead of createExpression.

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/test/Transforms/NewGVN/compare-condition-changes.ll:7
+
+define i1 @test1() {
+; CHECK-LABEL: @test1(
----------------
asbirlea wrote:
> What is the purpose of this test? I'm sorry if it's obvious, could you clarify?
I'll add a comment when committing. The test case is mostly to check that we handle the case where a non-constant expression is returned and we have to manually set Res.ExtraDep = nullptr. Looking back at now, it should have been added in the earlier patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99990/new/

https://reviews.llvm.org/D99990