[PATCH] D101231: [RFC][InlineCost] Don't count the cost of truly exceptionally unlikely blocks (PR50099)

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 24 07:18:14 PDT 2021


nikic added a comment.

Possibly I'm misunderstanding what is proposed here, but aren't these kind of very rarely executed blocks exactly what we do **not** want to inline? This would make sense in the context of something like partial inlining, where we could inline the hot parts without the cold parts (and thus not cost the cold parts), but for regular inlining this means we duplicate cold code, increasing code size and icache pressure.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101231/new/

https://reviews.llvm.org/D101231



More information about the llvm-commits mailing list