[PATCH] D101163: [AArch64] Prevent spilling between ldxr/stxr pairs

LemonBoy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Apr 24 00:49:32 PDT 2021


LemonBoy added a subscriber: efriedma.
LemonBoy added a comment.

In D101163#2712250 <https://reviews.llvm.org/D101163#2712250>, @tmatheson wrote:

> The same problem exists in the ARM backend, which I fixed internally by implementing new pseudos for the atomicrmw instructions, but hadn't got round to upstreaming it yet. Here it is for comparison: D101164 <https://reviews.llvm.org/D101164>.

That sounds like proper way of fixing this problem and produce tighter code.
This patch (or D101216 <https://reviews.llvm.org/D101216>, cc @efriedma) is IMO a good stopgap solution to avoid miscompiling rmw ops that can possibly land in LLVM 12.0.1.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101163/new/

https://reviews.llvm.org/D101163



More information about the llvm-commits mailing list