[PATCH] D101218: [lld/mac] add test coverage for -sectcreate and -order_file with --reproduce

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 19:05:22 PDT 2021


thakis created this revision.
thakis added a reviewer: lld-macho.
Herald added a project: lld-macho.
thakis requested review of this revision.

Would've caught the (since fixed) regression in D97610 <https://reviews.llvm.org/D97610>.

No behavior change.


https://reviews.llvm.org/D101218

Files:
  lld/test/MachO/reproduce.s


Index: lld/test/MachO/reproduce.s
===================================================================
--- lld/test/MachO/reproduce.s
+++ lld/test/MachO/reproduce.s
@@ -4,22 +4,32 @@
 # RUN: mkdir -p %t.dir/build1
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-macos %s -o %t.dir/build1/foo.o
 # RUN: echo '_main' > %t.dir/main.exports
+# RUN: echo '_main' > %t.dir/main.order
+# RUN: echo 'X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*' > %t.dir/sectdata.txt
 # RUN: cd %t.dir
 # RUN: %lld -platform_version macos 10.10.0 11.0 \
 # RUN:     -exported_symbols_list main.exports \
+# RUN:     -order_file main.order \
+# RUN:     -sectcreate __COMPLETELY __legit sectdata.txt \
 # RUN:     build1/foo.o -o bar --reproduce repro1.tar
 
 # RUN: tar tf repro1.tar | FileCheck -DPATH='%:t.dir' --check-prefix=LIST %s
 # LIST: repro1/response.txt
 # LIST: [[PATH]]/main.exports
 # LIST: [[PATH]]/build1/foo.o
+# LIST: [[PATH]]/main.order
+# LIST: [[PATH]]/sectdata.txt
 
 # RUN: tar xf repro1.tar
 # RUN: cmp build1/foo.o repro1/%:t.dir/build1/foo.o
 # RUN: diff main.exports repro1/%:t.dir/main.exports
+# RUN: diff main.order repro1/%:t.dir/main.order
+# RUN: diff sectdata.txt repro1/%:t.dir/sectdata.txt
 # RUN: FileCheck %s --check-prefix=RSP1 < repro1/response.txt
 # RSP1:      {{^}}-platform_version macos 10.10.0 11.0{{$}}
 # RSP1-NEXT: -exported_symbols_list [[BASEDIR:.+]]/main.exports
+# RSP1-NEXT: -order_file [[BASEDIR]]/main.order
+# RSP1-NEXT: -sectcreate __COMPLETELY __legit [[BASEDIR]]/sectdata.txt
 # RSP1-NOT:  {{^}}repro1{{[/\\]}}
 # RSP1-NEXT: [[BASEDIR]]/build1/foo.o
 # RSP1-NEXT: -o bar


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101218.340222.patch
Type: text/x-patch
Size: 1633 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210424/6d948194/attachment.bin>


More information about the llvm-commits mailing list