[PATCH] D95425: Implementation of global.get/set for reftypes in LLVM IR

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

In D95425#2711969 <https://reviews.llvm.org/D95425#2711969>, @pmatos wrote:

> Apparently `getTypeForEVT` in `LowerArguments` is only necessary to call the `getABIAlignmentForCallingConv`. I was thinking that since reference types really are pointers to different address spaces we could return their TypeForEVT as being int32. That will then return as the alignment for reference types the default alignment for int32. This should help with avoiding us touching middle end code. I will experiment in this direction.

Why not return the original pointer to opaque type, i.e. `PointerType::get(StructType::create(Context), 1)`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95425/new/

https://reviews.llvm.org/D95425