[PATCH] D99825: [cmake] Enable -Werror=return-type for clang

Dave Lee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 16:19:21 PDT 2021


kastiglione added a comment.

In D99825#2672670 <https://reviews.llvm.org/D99825#2672670>, @dblaikie wrote:

> @aaron.ballman's point that maybe this should be -Werror by default in clang sounds plausible - because not all projects will be using -Werror, etc. If that helps some users who work on LLVM itself but don't want to turn on -Werror (not sure why - the buildbots will do it and so things will break/you'll have to fix stuff if you're not building with -Werror using a fairly recent clang) that's OK.

thanks, I'll open a diff to make `return-type` and error by default and see how that goes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99825/new/

https://reviews.llvm.org/D99825



More information about the llvm-commits mailing list