[PATCH] D101180: Mark type test intrinsics as speculatable to fix inline cost

[David Zarzycki via Phabricator via llvm-commits]

davezarzycki added a comment.

I have an auto bisecting cron job that has twice identified this change as the source of a regression when building release (no asserts). Is the following expected or can we get a quick fix?

  FAIL: LLVM :: Transforms/Inline/ephemeral.ll (57376 of 76078)
  ******************** TEST 'LLVM :: Transforms/Inline/ephemeral.ll' FAILED ********************
  Script:
  --
  : 'RUN: at line 1';   /tmp/_update_lc/r/bin/opt -S -inline /home/dave/ro_s/lp/llvm/test/Transforms/Inline/ephemeral.ll -debug-only=inline-cost 2>&1 | /tmp/_update_lc/r/bin/FileCheck /home/dave/ro_s/lp/llvm/test/Transforms/Inline/ephemeral.ll
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/dave/ro_s/lp/llvm/test/Transforms/Inline/ephemeral.ll:4:10: error: CHECK: expected string not found in input
  ; CHECK: NumInstructions: 2
           ^
  <stdin>:1:1: note: scanning from here
  opt: Unknown command line argument '-debug-only=inline-cost'. Try: '/tmp/_update_lc/r/bin/opt --help'
  ^
  <stdin>:2:33: note: possible intended match here
  opt: Did you mean '--debug-pass=inline-cost'?
                                  ^
  
  Input file: <stdin>
  Check file: /home/dave/ro_s/lp/llvm/test/Transforms/Inline/ephemeral.ll
  
  -dump-input=help explains the following input dump.
  
  Input was:
  <<<<<<
             1: opt: Unknown command line argument '-debug-only=inline-cost'. Try: '/tmp/_update_lc/r/bin/opt --help'
  check:4'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
             2: opt: Did you mean '--debug-pass=inline-cost'?
  check:4'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  check:4'1                                     ?              possible intended match
  >>>>>>
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  ********************
  Failed Tests (1):
    LLVM :: Transforms/Inline/ephemeral.ll


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101180/new/

https://reviews.llvm.org/D101180