[lld] 035eb6d - [lld-macho]][nfc] Fix some typos + rephrase a comment

Jez Ng via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 15:05:58 PDT 2021


Author: Jez Ng
Date: 2021-04-23T18:05:48-04:00
New Revision: 035eb6d154a1f4827eabc29d02d17e69fc939202

URL: https://github.com/llvm/llvm-project/commit/035eb6d154a1f4827eabc29d02d17e69fc939202
DIFF: https://github.com/llvm/llvm-project/commit/035eb6d154a1f4827eabc29d02d17e69fc939202.diff

LOG: [lld-macho]][nfc] Fix some typos + rephrase a comment

I was a bit confused by the comment because I thought that "Tests
that..." was describing the tests contained within the same file.

Reviewed By: #lld-macho, thakis

Differential Revision: https://reviews.llvm.org/D101160

Added: 
    

Modified: 
    lld/MachO/SyntheticSections.cpp
    lld/test/MachO/private-extern.s

Removed: 
    


################################################################################
diff  --git a/lld/MachO/SyntheticSections.cpp b/lld/MachO/SyntheticSections.cpp
index 51922d95adf2..8b1616f415a4 100644
--- a/lld/MachO/SyntheticSections.cpp
+++ b/lld/MachO/SyntheticSections.cpp
@@ -1115,12 +1115,12 @@ void macho::createSyntheticSymbols() {
     if (config->isPic)
       symtab->addSynthetic("__mh_execute_header", in.header->isec, 0,
                            /*privateExtern=*/false,
-                           /*includeInSymbtab=*/true);
+                           /*includeInSymtab=*/true);
     else
       symtab->addSynthetic("__mh_execute_header",
                            /*isec*/ nullptr, 0,
                            /*privateExtern=*/false,
-                           /*includeInSymbtab=*/true);
+                           /*includeInSymtab=*/true);
     break;
 
     // The following symbols are  N_SECT symbols, even though the header is not

diff  --git a/lld/test/MachO/private-extern.s b/lld/test/MachO/private-extern.s
index 320e1a97232d..cfc65651eb44 100644
--- a/lld/test/MachO/private-extern.s
+++ b/lld/test/MachO/private-extern.s
@@ -20,8 +20,8 @@
 # EXPORTS-NM-DAG: (__TEXT,__cstring) non-external (was a private external) _foo
 # EXPORTS-NM-DAG: (__TEXT,__cstring) external _bar
 
-# Tests that weak private_exten symbols aren't referenced in the
-# weak bind table are in weak-private.extern.s
+## The tests for weak .private_extern symbols not being referenced in the
+## weak bind table can be found in weak-private-extern.s
 
 #--- basics.s
 .section __TEXT,__cstring


        


More information about the llvm-commits mailing list