[PATCH] D101195: [CSSPGO] Fix missing debug info of dangling pseudo probe

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-dangle2.ll:184
+
+; Test to make sure the dangling probe's metadata not being dropped.
+; CHECK: call void @llvm.pseudoprobe(i64 -4224472938262609671, i64 5, i32 2, i64 -1), !dbg !{{[0-9]+}}
----------------
Thanks for making the test. Can you move the checks to near beginning of the file and add a check for the function entry proceeding the probe? Otherwise lgtm.


================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-dangle2.ll:185
+; Test to make sure the dangling probe's metadata not being dropped.
+; CHECK: call void @llvm.pseudoprobe(i64 -4224472938262609671, i64 5, i32 2, i64 -1), !dbg !{{[0-9]+}}
----------------
Nit: `[[#]]` is a shortcut for matching decimal numbers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101195/new/

https://reviews.llvm.org/D101195