[PATCH] D75485: Support DW_FORM_strx* in llvm-dwp.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 13:58:55 PDT 2021


dblaikie added a comment.

In D75485#2711582 <https://reviews.llvm.org/D75485#2711582>, @kimanh wrote:

> Thanks a lot for the reviews!
>
> After reading up more on the DWARF specs, I noticed that debug abbrev offsets were not updated for dwarf 32-bit, and 64-bit. I've changed that now in the latest patch.

Pretty sure the dwp code doesn't handle DWARF64 at all - might be best to leave that code to a separate patch with dedicated testing. (if you really want to include it in this patch - please include tests for it)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75485/new/

https://reviews.llvm.org/D75485



More information about the llvm-commits mailing list