[PATCH] D101195: [CSSPGO] Fix missing debug info of dangling pseudo probe

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyCFG.cpp:2386
     if (!SpeculatedStoreValue || &I != SpeculatedStore)
       I.setDebugLoc(DebugLoc());
     I.dropUnknownNonDebugMetadata();
----------------
wlei wrote:
> wenlei wrote:
> > can we assert we are not dropping dbg metadata for any probes?
> Good point, assertion added.
`assert("..")` will not fire, i guess you meant something like `llvm_unreachable` here?. Though I think the convention is like this:

```
assert(!isa<PseudoProbeInst>(I) && "Should not drop debug info from any pseudo probes.");
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101195/new/

https://reviews.llvm.org/D101195