[PATCH] D83578: [test] Replace a fragile lit feature (substitution in an argument place) with command -v
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 23 12:39:44 PDT 2021
dblaikie added a comment.
FWIW I'm pretty ambivalent either way on this.
But this patch says it replaces the feature - which I don't think it does, since it doesn't remove the functionality from lit (& not sure if replaces all uses of the feature). I think if it's going to be removed, the functionality should be removed or we'll get more of it & more confusion about which way things should be done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83578/new/
https://reviews.llvm.org/D83578
More information about the llvm-commits
mailing list