[PATCH] D101182: [lld/mac] Support more flags for --reproduce

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/test/MachO/reproduce.s:8
 # RUN: cd %t.dir
-# RUN: %lld -platform_version macos 10.10.0 11.0 build1/foo.o -o bar --reproduce repro1.tar
-# RUN: tar xOf repro1.tar repro1/%:t.dir/build1/foo.o > build1-foo.o
-# RUN: cmp build1/foo.o build1-foo.o
+# RUN: %lld -platform_version macos 10.10.0 11.0 \
+# RUN:     -exported_symbols_list main.exports \
----------------
int3 wrote:
> can we remove `-platform_version` here now that we include it in lit.local.cfg?
the rsp check below matches the explicit versions here, and explicitly matching the ones from lit.local.cfg is maybe a bit awkward?


================
Comment at: lld/test/MachO/reproduce.s:31
 
+# RUN: cd repro1; %lld @response.txt
+
----------------
int3 wrote:
> technically an accurate reproduction command would just be `ld64.lld @response.txt` since the other flags will be included in the response file
good point, done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101182/new/

https://reviews.llvm.org/D101182