[PATCH] D101145: [MC][AMDGPU][llvm-objdump] Synthesized local labels in disassembly

[Tim Renouf via Phabricator via llvm-commits]

tpr marked an inline comment as done.
tpr added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1835
             TripleName, nullptr, nullptr, &Symbols, &Ctx, std::move(RelInfo)));
+        MCSymbolizer *SymbolizerPtr = &*Symbolizer;
+        DisAsm->setSymbolizer(std::move(Symbolizer));
----------------
rochauha wrote:
> I think it would help if this logic is moved to a separate function in the tool, that is called conditionally. It would make the main loop shorter and perhaps also easier to read?
I extracted the whole AMDGPU adding symbolizer stuff, including my new code, into a new func. Is that ok?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101145/new/

https://reviews.llvm.org/D101145