[PATCH] D101093: [VPlan] Add VPBlockUtils::basicBlocksOnly helper.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 10:19:19 PDT 2021


fhahn added a comment.

In D101093#2709842 <https://reviews.llvm.org/D101093#2709842>, @a.elovikov wrote:

> VPlan part looks good to me. I'm not familiar with implementation details of the `filtered_iterator` to discuss the `to_reference->filter->to_pointer` approach though. Regardless of that, it's an improvement in interfaces, so LGTM unless someone has a way to make filtering work with pointer directly.

Thanks for taking a look! If it turns out there's a better way to implement the interface I'm move than happy to adjust this, even after it goes in :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101093/new/

https://reviews.llvm.org/D101093



More information about the llvm-commits mailing list