[PATCH] D99055: [llvm-objcopy] Refactor CopyConfig structure.

Fri Apr 23 09:33:38 PDT 2021

avl updated this revision to Diff 340083.
avl added a comment.

Implemented as suggested.

It seems to me that this version(using encapsulation instead of inheritance) 
became more complex because of the necessity to repeatedly specify the name of the config 
and to pass pair of configs. To minimize the number of changes we might use inheritance 
like in this change(https://reviews.llvm.org/D99055?id=334944). 
If the complexity is not a problem, then let`s use a variant from this last version of the patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99055/new/

https://reviews.llvm.org/D99055

Files:
  llvm/tools/llvm-objcopy/CMakeLists.txt
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  llvm/tools/llvm-objcopy/COFF/COFFObjcopy.h
  llvm/tools/llvm-objcopy/COFFConfig.h
  llvm/tools/llvm-objcopy/CommonConfig.h
  llvm/tools/llvm-objcopy/ConfigManager.cpp
  llvm/tools/llvm-objcopy/ConfigManager.h
  llvm/tools/llvm-objcopy/CopyConfig.cpp
  llvm/tools/llvm-objcopy/CopyConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFConfig.cpp
  llvm/tools/llvm-objcopy/ELF/ELFConfig.h
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.cpp
  llvm/tools/llvm-objcopy/ELF/ELFObjcopy.h
  llvm/tools/llvm-objcopy/ELF/Object.h
  llvm/tools/llvm-objcopy/ElfConfig.h
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
  llvm/tools/llvm-objcopy/MachO/MachOObjcopy.h
  llvm/tools/llvm-objcopy/MachOConfig.h
  llvm/tools/llvm-objcopy/MultiFormatConfig.h
  llvm/tools/llvm-objcopy/WasmConfig.h
  llvm/tools/llvm-objcopy/llvm-objcopy.cpp
  llvm/tools/llvm-objcopy/llvm-objcopy.h
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp
  llvm/tools/llvm-objcopy/wasm/WasmObjcopy.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D99055.340083.patch
Type: text/x-patch
Size: 105685 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210423/a347032f/attachment-0001.bin>