[PATCH] D101160: [lld-macho]][nfc] Fix some typos + rephrase a comment

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 06:45:12 PDT 2021


int3 created this revision.
int3 added reviewers: lld-macho, thakis.
Herald added a project: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

I was a bit confused by the comment because I thought that "Tests
that..." was describing the tests contained within the same file.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D101160

Files:
  lld/MachO/SyntheticSections.cpp
  lld/test/MachO/private-extern.s


Index: lld/test/MachO/private-extern.s
===================================================================
--- lld/test/MachO/private-extern.s
+++ lld/test/MachO/private-extern.s
@@ -20,8 +20,8 @@
 # EXPORTS-NM-DAG: (__TEXT,__cstring) non-external (was a private external) _foo
 # EXPORTS-NM-DAG: (__TEXT,__cstring) external _bar
 
-# Tests that weak private_exten symbols aren't referenced in the
-# weak bind table are in weak-private.extern.s
+## The tests for weak .private_extern symbols not being referenced in the
+## weak bind table can be found in weak-private-extern.s
 
 #--- basics.s
 .section __TEXT,__cstring
Index: lld/MachO/SyntheticSections.cpp
===================================================================
--- lld/MachO/SyntheticSections.cpp
+++ lld/MachO/SyntheticSections.cpp
@@ -1115,12 +1115,12 @@
     if (config->isPic)
       symtab->addSynthetic("__mh_execute_header", in.header->isec, 0,
                            /*privateExtern=*/false,
-                           /*includeInSymbtab=*/true);
+                           /*includeInSymtab=*/true);
     else
       symtab->addSynthetic("__mh_execute_header",
                            /*isec*/ nullptr, 0,
                            /*privateExtern=*/false,
-                           /*includeInSymbtab=*/true);
+                           /*includeInSymtab=*/true);
     break;
 
     // The following symbols are  N_SECT symbols, even though the header is not


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D101160.340005.patch
Type: text/x-patch
Size: 1454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210423/16601e62/attachment.bin>


More information about the llvm-commits mailing list