[PATCH] D100121: [LV] Let selectVectorizationFactor reason directly on VectorizationFactor.

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h:191
   static VectorizationFactor Disabled() {
     return {ElementCount::getFixed(1), 0};
   }
----------------
Hi Sander, a minor question here: for scalable vectorization do you plan to change the definition of `Disabled`? Perhaps this may not be needed?

We were considering something like `return {ElementCount:getNull(), 0};` so this `VectorizationFactor` value is effectively not a valid vectorization factor at all. But maybe this is not the intent of `Disabled`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100121/new/

https://reviews.llvm.org/D100121