[PATCH] D100495: [SLP] Add detection of shuffled/perfect matching of tree entries.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 23 04:38:10 PDT 2021


ABataev added a comment.

In D100495#2711644 <https://reviews.llvm.org/D100495#2711644>, @bkramer wrote:

> Seeing a miscompile after this has landed. Trying to reduce a test case, but no luck so far.

Thanks for the report, waiting for the reproducer.



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4305
+    return TargetTransformInfo::SK_PermuteTwoSrc;
+  }
+  return None;
----------------
RKSimon wrote:
> This shuffle kind decode code feels like the kind of thing it should be somewhere like Analysis\VectorUtils.h ?
Yes, that would be good, just need to agree where we should this, in `getShuffleCost` or somewhere else?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100495/new/

https://reviews.llvm.org/D100495



More information about the llvm-commits mailing list