[PATCH] D100765: [flang] Update format tests to use GTest

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added inline comments.


================
Comment at: flang/unittests/RuntimeGTest/Format.cpp:28-29
+  bool Emit(const char *, std::size_t);
+  bool Emit(const char16_t *, std::size_t);
+  bool Emit(const char32_t *, std::size_t);
+  bool AdvanceRecord(int = 1);
----------------
Could you copy the missing implementation across? Ta!


================
Comment at: flang/unittests/RuntimeGTest/Format.cpp:107
+
+  for (const auto [n, format, expect, repeat] : params) {
+    TestFormatContext context;
----------------
`const auto&` ? Otherwise  there is going to be a warning, and all warnings are treated as errors in Flang  :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100765/new/

https://reviews.llvm.org/D100765